-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bad representation of weight, volume
in CargoItem
#943
Comments
Please raise a PR. |
@OR13 , @mkhraisha
|
Decision here: #532 (comment) |
I think our final resolution is to use this layout: #532 (comment) i.e we should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@mkhraisha @BenjaminMoe @OR13 @nissimsan
Related to #532, these lines
traceability-vocab/docs/openapi/components/schemas/common/CargoItem.yml
Lines 52 to 61 in 8b5efda
traceability-vocab/docs/openapi/components/schemas/common/CargoItem.yml
Lines 69 to 77 in 8b5efda
have the following problems:
weightUnit, volumeUnit
as separate props at theCargoItem
level contradicts the discussion/decision in conflated units, weight vs netWeight, xsd:double vs xsd:decimal #532 to useMeasuredValue
orQuantitativeValue
: the unit should be inside such nodesvolume
says "Calculated by multiplying the width, height, and length" but there are no fieldsheight, length
volume
is mapped to https://vocabulary.uncefact.org/grossVolumeMeasure but that's a structured node with type https://vocabulary.uncefact.org/MeasureType with fieldsMeasureTypeCode
(unit),MeasureTypeValue
(value) wheres the examples showvolume
to be a decimal.The text was updated successfully, but these errors were encountered: