Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad representation of weight, volume in CargoItem #943

Closed
VladimirAlexiev opened this issue Mar 12, 2024 · 4 comments
Closed

bad representation of weight, volume in CargoItem #943

VladimirAlexiev opened this issue Mar 12, 2024 · 4 comments

Comments

@VladimirAlexiev
Copy link
Contributor

@mkhraisha @BenjaminMoe @OR13 @nissimsan
Related to #532, these lines

volume:
title: Volume
description: >-
Calculated by multiplying the width, height, and length of the packed
cargo.
type: number
$linkedData:
term: volume
'@id': >-
https://vocabulary.uncefact.org/grossVolumeMeasure

volumeUnit:
title: Volume Unit
description: >-
The unit of measure which can be expressed in either imperial or metric
terms
type: string
$linkedData:
term: volumeUnit
'@id': https://schema.org/unitCode

have the following problems:

@OR13
Copy link
Collaborator

OR13 commented Mar 12, 2024

Please raise a PR.

@VladimirAlexiev
Copy link
Contributor Author

@OR13 , @mkhraisha
Before anyone can make a PR, there must be agreement how to represent measurements

  • a simple literal as most of them are?
    • xsd:decimal or xsd:double?
  • or an intermediate node that carries value, unit?

@nissimsan
Copy link
Collaborator

Decision here: #532 (comment)

@mkhraisha
Copy link
Collaborator

I think our final resolution is to use this layout: #532 (comment)

i.e we should use xsd:decimal and we should use QuantitativeValue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants