-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage Accessibility Improvements #368
Comments
This is addressed, in part, by #366. I say "in part", because it does move the skip link to be the first element on the page, but it doesn't move it outside of the nav. That would represent a WCAG failure and usability issue, because then the skip link wouldn't be encompassed by any landmark at all. To address this, I suggest a
This doesn't semantically feel quite right. I see this text as a subtitle of the home page/project as a whole, and therefore it would be more appropriate as plain text (styling aside). If my reading of that situation is wrong, and it is actually intended to be a sibling of "How are we improving interoperability?", then an |
@jscholes thanks for the quick reply! r.e. skip link, I didn't think about the overlap with #366, but if I'm understanding your proposal correctly, it seems compatible with the intent behind Matt's suggested mitigation. r.e. changing the mission statement to H2, I wanted to followup with you about this as I know you expressed some hesitation about this approach. I think Matt's suggestion indeed presumes that the statement is a sibling of "How are we improving interoperability?" but I'll let him comment on this, directly. cc @mcking65 |
If #366 is merged as is, the structure would go:
This is somewhat nonstandard; most websites we work on have a header wrapping the skip link, Home link and nav, i.e.:
In this case, we left the nav (in effect) acting as the header in the PR, to avoid making too many Bootstrap-related changes (@jkva can elucidate further on that if required). It would futureproof the app a bit, though, e.g. if search or other functions are added to the header in the future. So I would vote for that, and it's not a lot of work. |
from Matt King, 1:1 feedback:
aria-label="ARIA-AT Home"
attributeThe text was updated successfully, but these errors were encountered: