-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-text-decor] Can text-decoration-thickness mix percentages and lengths? #9469
Comments
I would expect |
Yeah, I also think |
@nt1m wrote:
Agree, that would make sense. We parse as ConsumeLengthOrPercent, (impl) |
…ined in text-decoration-thickness and text-underline-offset #9469
Quite sure this was not intentional. Likely at the time this was written, there was no distinction between |
@fantasai You fixed the grammar, but the prose below still tries to define |
Instead of having a separate definition for `<length>` and `<percentage>`. Fixes #9469
There's a WPT testing that
text-decoration-thickness
takescalc()
mixing percentages and lengths.https://github.com/web-platform-tests/wpt/blob/b5c73fa21b/css/css-text-decor/text-decoration-thickness-valid.html#L24-L25
Except the spec specifies the syntax to be:
auto | from-font | <length> | <percentage>
, which means that they can't actually be mixed? If they are allowed to be mixed, the type should probably be<length-percentage>
.It seems like the mixing is supported in Firefox / Chrome. Safari doesn't currently support percentages.
cc @kojiishi @fantasai @shivamidow
The text was updated successfully, but these errors were encountered: