Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Default display mode" section is super confusing #1024

Open
fantasai opened this issue Dec 3, 2021 · 2 comments
Open

"Default display mode" section is super confusing #1024

fantasai opened this issue Dec 3, 2021 · 2 comments

Comments

@fantasai
Copy link

fantasai commented Dec 3, 2021

The concept of "default display mode" is very confusing. Is it the mode requested by the app manifest? The mode the UA would have defaulted to if there is no request from an app manifest? The display mode that is actually in effect at the end of the day?

It would be much easier to follow this section if there were two named concepts neither of which use the word "default":

  • requested display mode - the mode requested by app manifest
  • effective display mode - the mode actually effective on the document after consideration of the app manifest, user preferences/overrides, and UA constraints

(It also needs to be clarified whether the display-mode media query reflects the effective display mode, requested display mode, or something else.)

@frivoal
Copy link
Contributor

frivoal commented Dec 3, 2021

Consider this sentence (at the end of section 7.1):

A user agent MUST reflect the applied display mode of the web application via a CSS media query [MEDIAQ].

If the user has overridden the manifest's display value, which way is the media feature supposed to go? Is this phrase deliberately not using the term "default display mode" to express some conceptual difference? If so, I can't what the difference is because both this sentence and the definition of "default display mode" rely on the term "apply".

Relatedly, the definition of apply itself could use some help too: the definition says what it means to apply a manifest (when it "affects the presentation or behavior of a browsing context"), but it doesn't say what it means to apply a member of a manifest, though it gets used that way. Are all members considered to apply if the manifest as a whole applies, or to they only apply if they individually made some difference? Do they count as not applying if they've been overridden by the user?

@marcoscaceres
Copy link
Member

All good points (it's definitely confusing)... will see if we can come up with something better. Appreciate the suggestions and feedback 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants