Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Languages in Reference Implementation #55

Open
schnelle opened this issue May 27, 2024 · 0 comments
Open

Consider Languages in Reference Implementation #55

schnelle opened this issue May 27, 2024 · 0 comments

Comments

@schnelle
Copy link
Collaborator

Language is an important aspect in processing of requests to IPAs. This is currently not considered.

@schnelle schnelle self-assigned this May 27, 2024
schnelle added a commit that referenced this issue Jun 18, 2024
- Introduced a new `Language` class in `Language.h` and `Language.cpp` within the `w3c::voiceinteraction::ipa` namespace, implementing RFC 1766 language tags. This class supports language identification through primary and subtags, adhering to ISO 639 and ISO 3166 standards, and includes a constructor, destructor, and a `toString` method.

- Added comprehensive documentation at the beginning of both the `Language.h` and `Language.cpp` files, referencing the IPA Reference Implementation by W3C, including copyright notice for 2024, and a disclaimer under the W3C Software and Document License.

- Removed extraneous whitespace in `ModalityType.cpp` to enhance readability and ensure coding style consistency.
schnelle added a commit that referenced this issue Jun 18, 2024
schnelle added a commit that referenced this issue Sep 19, 2024
Introduced LanguageDependent class with a pure virtual getLanguage method.
Updated MetaData and TextMultiModalInput to handle language settings.
Enhanced Timestamp class to provide ISO 8601 string representation.
Modified constructors and methods to support new language features.
Updated CMakeLists.txt to include new and modified source files.
schnelle added a commit that referenced this issue Sep 27, 2024
The `Language` class in `Language.h` now includes static constant instances for various languages (e.g., DE, EN, ES, FR, IT, JA, KO, NL, PL, PT, RU, ZH). These instances are publicly accessible. The `private` access specifier has been adjusted to accommodate these new public static constants. Corresponding definitions have been added to `Language.cpp`, initializing each constant with a specific language code (e.g., "de" for German, "en" for English, etc.).
schnelle added a commit that referenced this issue Oct 7, 2024
- Introduced `Dialog Manager` to handle good and erroneous calls.
- Added chained filter for selecting IPA providers by modality and language.
- Updated `ProviderSelectionService` to use the new filter strategy.
- Renamed `ChatGPTAdapter` to `ChatGPTIPAProvider`.
- Updated processing chain to include `ipaDialogManager` before `ipaService`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant