Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a clearer error when Safari Technology Preview isn't installed #48764

Open
gsnedders opened this issue Oct 23, 2024 · 0 comments
Open

Give a clearer error when Safari Technology Preview isn't installed #48764

gsnedders opened this issue Oct 23, 2024 · 0 comments
Labels
infra wpt wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

By default you get something like:

gsnedders@gsnedders-margot web-platform-tests % ./wpt run safari foo 
/Volumes/gsnedders/projects/wpt/web-platform-tests/_venv3/lib/python3.9/site-packages/urllib3/__init__.py:35: NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 3.3.6'. See: https://github.com/urllib3/urllib3/issues/3020
  warnings.warn(
Traceback (most recent call last):
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/./wpt", line 10, in <module>
    wpt.main()
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/wpt.py", line 233, in main
    rv = script(*args, **kwargs)
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 994, in run
    setup_cls, wptrunner_kwargs = setup_wptrunner(venv, **kwargs)
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 966, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 248, in setup
    self.setup_kwargs(kwargs)
  File "/Volumes/gsnedders/projects/wpt/web-platform-tests/tools/wpt/run.py", line 740, in setup_kwargs
    raise WptrunError("Unable to locate safaridriver binary")
tools.wpt.run.WptrunError: Unable to locate safaridriver binary

This is a pretty bad user experience; it's not at all obvious what it was looking for (/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver).

@gsnedders gsnedders added infra wpt wptrunner The automated test runner, commonly called through ./wpt run labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wpt wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

1 participant