Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classifier for license in pyproject.toml #167

Closed
sevdog opened this issue Jun 14, 2024 · 0 comments · Fixed by #170
Closed

Use classifier for license in pyproject.toml #167

sevdog opened this issue Jun 14, 2024 · 0 comments · Fixed by #170

Comments

@sevdog
Copy link
Contributor

sevdog commented Jun 14, 2024

Providing the licence file in the pyproject.toml is admitted but in that way the metadata of the package is very verbose and may break tools which are intended to parse known licence names (like MPL 2.0).

It would be better to provide the appropriate classifier : LICENSE :: OSI APPROVED :: MOZILLA PUBLIC LICENSE 2.0 (MPL 2.0).

Ref: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

I am very confused by the statement here:

pywebpush/pyproject.toml

Lines 18 to 20 in c99d0f7

# Use the LICENSE file for our license, since "MPL2" isn't included in the
# canonical list
license = { file = "LICENSE" }

Since the MPL has a canonical identifier: https://spdx.org/licenses/MPL-2.0.html

@sevdog sevdog changed the title Use classifiers Use classifier for license in pyproject.toml Jun 14, 2024
sevdog added a commit to sevdog/pywebpush that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant