Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires parameters that aren't provided by client side #199

Open
Oberonc opened this issue Oct 25, 2022 · 0 comments
Open

Requires parameters that aren't provided by client side #199

Oberonc opened this issue Oct 25, 2022 · 0 comments

Comments

@Oberonc
Copy link

Oberonc commented Oct 25, 2022

This library force the user to get 2 parameters from the client side that simply dont exist in other implementations:

// Get public key and user auth from the subscription object
    var key = subscription.getKey ? subscription.getKey('p256dh') : '';
    var auth = subscription.getKey ? subscription.getKey('auth') : '';

For example, nothing about these parameters shows here.
In Elemental2 there is no "getKey" in the API as seen here:

@JsType(isNative = true, namespace = JsPackage.GLOBAL)
public class PushSubscription {
  public String endpoint;
  public PushSubscriptionOptions options;
  public String subscriptionId;

  public native Promise<Boolean> unsubscribe();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant