Automatically give penalty when payment is overdue #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
+ Coverage 89.11% 89.13% +0.02%
==========================================
Files 682 683 +1
Lines 21464 21533 +69
==========================================
+ Hits 19128 19194 +66
- Misses 2336 2339 +3 ☔ View full report in Codecov by Sentry. |
itsisak
force-pushed
the
automatic-penalty
branch
from
5744627
to
11f50ab
Compare
falbru
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this checks every day at 2100 if there is any events with overdue payments. If so it gives penalty to the users who have not paid, unregisters them from the event and sends notification.
This is a first draft of the consept. Future improvements should be to check if they paid after the set deadline, not just at 2100. Also the notification to the event creator could be removed if this is solution is satisfactory.
Also im not married to the names like
event_payment_overdue_penaltyi will try to think of some better, but it is conflicting with the currently existingpayment_overduefunctionalities (which is more likepayment_due)Resolves ABA-30