Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test violations codes and docs #12

Open
sobolevn opened this issue Dec 11, 2018 · 6 comments
Open

Test violations codes and docs #12

sobolevn opened this issue Dec 11, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sobolevn
Copy link
Member

We need to tests that all violations

  1. have unique codes
  2. correctly sorted inside the code
  3. have docs in the module docstrings

You can have a look at the example (this code can be even copy-pasted): https://github.com/wemake-services/wemake-python-styleguide/tree/master/tests/test_violations

@sobolevn sobolevn added enhancement New feature or request help wanted Extra attention is needed labels Dec 11, 2018
@sobolevn sobolevn mentioned this issue May 30, 2019
@kaelscion
Copy link
Collaborator

Awesome! I'll get a look at it this week (super busy with a new contract).

@sobolevn
Copy link
Member Author

sobolevn commented Jun 4, 2019

Awesome! Thanks.

@kaelscion
Copy link
Collaborator

I've got the violations testing in order but noticed that we don't have a config.py for this project, unlike the example. In the example, the Configuration object is needed in the final function in test_docs.py to ensure that all documentation for all configurations is available. Is there an equivalent configuration file I should use for this instance that I just don't see or are we not using one?

@sobolevn
Copy link
Member Author

sobolevn commented Jun 7, 2019

Not yet. 🙁

kaelscion pushed a commit to kaelscion/dotenv-linter that referenced this issue Jun 15, 2019
kaelscion pushed a commit to kaelscion/dotenv-linter that referenced this issue Jun 15, 2019
@nifadyev
Copy link

Hello @sobolevn , are you interested in completing this issue? I may finish the work done in this PR. It seems mostly done but needs some polishing.

@sobolevn
Copy link
Member Author

Yes, please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants