Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test each unique violation #13

Open
sobolevn opened this issue Dec 11, 2018 · 0 comments
Open

Test each unique violation #13

sobolevn opened this issue Dec 11, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sobolevn
Copy link
Member

We need to create integration tests for all violations.

How should it look like?

  1. We create a folder tests/fixtures/integration
  2. We create a folder called tests/test_violations/ where all other tests will be located
  3. Inside tests/test_violations/ we create a single test_VIOLATION_TYPE/ subfolder for all violation types
  4. Then we create individual tests file for each violation class in the corresponding types subfolders

How should it work?

  1. We create a fixture file with .env contents
  2. We start a new process with Popen to lint this fixture with dotenv-linter command
  3. We check the outputs

Example: https://github.com/wemake-services/wemake-python-styleguide/blob/master/tests/test_plugins.py

@sobolevn sobolevn added enhancement New feature or request help wanted Extra attention is needed labels Dec 11, 2018
@sobolevn sobolevn mentioned this issue May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant