Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment settings objects used when fetching a module worker script graph are still wrong #9535

Closed
nicolo-ribaudo opened this issue Jul 19, 2023 · 0 comments · Fixed by #9541

Comments

@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Jul 19, 2023

Re-reading #9520 to give consistent names to the various "environment settings object" parameters, I noticed that the logic is still wrong.

  • Before that PR, the top-level worker module script was fetched with outside settings and its settings object was set to inside settings. Then, all its dependencies where fetched with inside settings and their settings object was inside settings.
  • After that PR, all its dependencies are fetched with outide settings and their settings object is outside settings.

where outside settings and inside settings are defined in https://html.spec.whatwg.org/#worker-processing-model

The settings object of all the dependencies should be inside settings instead, while keeping the fetch client as outside settings.

I will open a PR after #9530 is merged, assuming that it will happen soon.

(fyi @allstarschh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants