Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a new user, CSS and JS minification are enabled by default #6862

Open
benorfaz opened this issue Aug 9, 2024 · 1 comment
Open

As a new user, CSS and JS minification are enabled by default #6862

benorfaz opened this issue Aug 9, 2024 · 1 comment
Labels
module: minify CSS module: minify JS needs: documentation Issues which need to create or update a documentation type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.18

Comments

@benorfaz
Copy link

benorfaz commented Aug 9, 2024

Context
The minification feature is mature and doesn't cause major issues. We can activate it by default so new users don't have to think about it.

Acceptance Criteria

  • When I install WP Rocket and activate it, CSS and JS minification are enabled
  • I toggle it on/off and save changes (as of today)
  • When I update from a previous a version of WP Rocket, and minification was disabled, it is still disabled
  • UX fix: Behavior is not consistent across features when toggling on-off. For minification, you must save settings before the exclusion box appears, which is not the case for others. Expectated behavior: when toggling on -> extra parameters (exclusion box) is immediately displayed.

Additional information
Add any additional information that could help or be relevant.
@benorfaz benorfaz added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: minify CSS module: minify JS labels Aug 9, 2024
@camilamadronero camilamadronero added the needs: documentation Issues which need to create or update a documentation label Aug 9, 2024
@benorfaz benorfaz added this to the 3.18 milestone Sep 5, 2024
@MathieuLamiot
Copy link
Contributor

Duplicate of #7038

@MathieuLamiot MathieuLamiot marked this as a duplicate of #7038 Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: minify CSS module: minify JS needs: documentation Issues which need to create or update a documentation type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.18
Development

No branches or pull requests
3 participants
@benorfaz @MathieuLamiot @camilamadronero