Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on BerlinDB update and questions #6986

Closed
MathieuLamiot opened this issue Sep 20, 2024 · 4 comments · Fixed by #7008
Closed

Follow-up on BerlinDB update and questions #6986

MathieuLamiot opened this issue Sep 20, 2024 · 4 comments · Fixed by #7008
Assignees
Milestone

Comments

@MathieuLamiot
Copy link
Contributor

Context
https://wp-media.slack.com/archives/CUT7FLHF1/p1726744353109299?thread_ts=1726053914.810439&cid=CUT7FLHF1
berlindb/core#166 (comment)

With our recent contribution to BerlinDB, we should keep the discussion going to ensuer we won't break website compatibility with the DB read access on information_schema, and leverage the opportunity to discuss BerlinDB unit testing.

Expected outcome

@MathieuLamiot
Copy link
Contributor Author

I could not find specific discussions related to possible issues with accessing information_scheme with WordPress, and WordPress Core does it itself, so let's try to move forward.
@wp-media/engineering-plugin-team Can someone take care of the 2nd bullet point, using this issue for tracking? We should update our dependency to benefit from the latest BerlinDB update. Thanks.

@Khadreal Khadreal self-assigned this Oct 3, 2024
Khadreal added a commit that referenced this issue Oct 3, 2024
@Khadreal Khadreal linked a pull request Oct 3, 2024 that will close this issue
6 tasks
@hanna-meda
Copy link

Related Test Plan HERE.

@remyperona
Copy link
Contributor

Should this be in 3.17.1 or 3.17.2? @piotrbak

@piotrbak
Copy link
Contributor

piotrbak commented Oct 8, 2024

@Tabrisrp since it's already tested we can move it into 3.17.1, thanks for asking!

@piotrbak piotrbak added this to the 3.17.1 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants