Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furo theme Xarray styling is bad on non-chromium browsers #73

Closed
kmpaul opened this issue Apr 19, 2022 · 3 comments
Closed

Furo theme Xarray styling is bad on non-chromium browsers #73

kmpaul opened this issue Apr 19, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@kmpaul
Copy link
Contributor

kmpaul commented Apr 19, 2022

What is your issue?

The styling fix implemented for Xarray HTML reprs when used with the Furo Sphinx theme only works for Chrome. It needs further investigation for Safari and Firefox browsers.

@kmpaul kmpaul added the bug Something isn't working label Apr 19, 2022
@kmpaul kmpaul mentioned this issue Apr 19, 2022
3 tasks
@kmpaul
Copy link
Contributor Author

kmpaul commented Apr 19, 2022

Turns out the fix for this was very easy. The hack I implemented initially in #72 implemented a function that assigned a value to a const, which should not be allowed. Turns out Chrome was a bit forgiving, while Safari and Firefox were not. Thus, I just changed the problem variable from a const to a var and it now works in Chrome, Safari, and Firefox.

@kmpaul
Copy link
Contributor Author

kmpaul commented Apr 19, 2022

Note that this should be closed and the hack should no longer be needed when a new release of Xarray is minted.

@kmpaul
Copy link
Contributor Author

kmpaul commented Apr 19, 2022

I'm going to close this now and point to #74 when the next Xarray release is minted.

@kmpaul kmpaul closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant