Try to detect circular dependencies

[MartijnKaijser]

Sometimes developers add circular dependencies by accident which freaks out Kodi. Doesn't happen often but it's quite nasty and we had lots of problems with this since add-ons where added to XBMC

<addon id="plugin.video.fattoquotidianotv" name="Il Fatto Quotidiano TV" version="1.0.4" provider-name="NeverWise"> <requires> <import addon="xbmc.python" version="2.14.0"/> <import addon="script.module.neverwise" version="1.0.6"/> <import addon="plugin.video.youtube" version="4.4.10" optional="true"/> <import addon="plugin.video.serviziopubblico" version="1.0.6" optional="true"/> </requires>

<addon id="plugin.video.serviziopubblico" name="Servizio Pubblico" version="1.0.6" provider-name="NeverWise"> <requires> <import addon="xbmc.python" version="2.14.0"/> <import addon="script.module.neverwise" version="1.0.6"/> <import addon="plugin.video.fattoquotidianotv" version="1.0.4" optional="true"/> </requires>

[mzfr]

This one could be a bit tricky because when we'll be checking the dependencies of an addon say plugin.video.fattoquotidianotv, we'll have to go on all the add-ons present in the requires section. And by go means sending requests to all require add-ons and getting the addon.xml files for them and then reading dependencies and matching it.

[MartijnKaijser]

Now you know why Kodi freaks out if we have these addons in repo :)

[Rechi]

addons.xml contains all the info. Besides that the checker doesn't consider anything else then addons.xml (from the server) and the local addon.xml of the currently checked addon.