Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast of code listings #747

Open
LiuSuY opened this issue Nov 17, 2017 · 10 comments
Open

Improve contrast of code listings #747

LiuSuY opened this issue Nov 17, 2017 · 10 comments

Comments

@LiuSuY
Copy link

LiuSuY commented Nov 17, 2017

官方地址 http://yeoman.io/learning/

First thing is to install yo using npm:

下面的命令行
离电脑稍微远一点点时 只能看见一个黑块 不仔细看都无法发现里面还有命令

@mischah
Copy link
Member

mischah commented Nov 17, 2017

Sorry, please open issues using english. Otherwise the maintainers of Yeoman won’t be able to help you 😞

@mischah mischah closed this as completed Nov 17, 2017
@SBoudrias
Copy link
Member

From what I understand, he's asking if we'd be open to change the code blocks background color as the contrast is hard to read.

@mischah
Copy link
Member

mischah commented Nov 17, 2017

Are we open?
I personally don’t fell the need. And my contrast ratio checker says it’s a AAA contrast:
image

What’s your opinion?

@LiuSuY
Copy link
Author

LiuSuY commented Nov 17, 2017

Yeah, that's what I want ,So, even if it's a little distance away from the computer, it doesn't seem to be too much effort. In personal terms, it's just a suggestion to make it look less powerful,I hope you can understand what I mean, even though I see your reply to me and reply to you through translation software.

example

image

image

@mischah mischah changed the title 建议修改文字背景颜色为白色 Improve contrast of code listings Nov 17, 2017
@mischah
Copy link
Member

mischah commented Nov 17, 2017

We might want switch to Prism since it’s more lightweight than highlight.js

@mischah mischah reopened this Nov 17, 2017
@mischah
Copy link
Member

mischah commented Nov 17, 2017

Guess we can call this an »actionable«.

@mischah
Copy link
Member

mischah commented Nov 17, 2017

Oh. interesting. It looks like that on my machine:
image

@LiuSuY
Copy link
Author

LiuSuY commented Nov 17, 2017

Yes, it's fun, and you can see it clearly even on the back of your seat
是的,很有趣,即使靠在座椅的做背上也能看得很清晰

@SBoudrias
Copy link
Member

@LiuSuY 上网的时候你用 Chrome 了吗。

@LiuSuY
Copy link
Author

LiuSuY commented Nov 17, 2017

不用chrome 或者火狐难道用ie?
Doesn't chrome or Firefox use IE?

是的,我正在使用
Yes, I'm using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants