Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting options->feature->test does not have any effect #40

Open
dummdidumm opened this issue Apr 14, 2018 · 0 comments
Open

Setting options->feature->test does not have any effect #40

dummdidumm opened this issue Apr 14, 2018 · 0 comments

Comments

@dummdidumm
Copy link

Setting the feature "test" does not have any effect.

If I set following options:

{
  features: {test: false}
}

The test tab still appears.

This appears to happen because in https://github.com/zalmoxisus/remotedev-app/blob/705247aed25b4221ba3edab1f25b0b8453aadf44/src/app/containers/monitors/InspectorWrapper/index.js the default tabs are not enhanced with the tab "test" if the corresponding feature is true but rather if the lib is "redux".
This also means others using the extension (for example ngrx-devtools) will never see the test tab, even if setting {test: true}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant