Tiff zarr reader #295
Draft
Tiff zarr reader #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
TomNicholas
added
the
references generation
for more information, see https://pre-commit.ci
TomNicholas
commented
Nov 14, 2024
virtualizarr/readers/zarr.py
Outdated
Comment on lines
41
to
48
| def chunkmanifest_from_zarr_array(za: zarr.Array) -> ChunkManifest: | ||
| import ujson | ||
|
|
||
| of2 = io.StringIO() | ||
|
|
||
| # TODO handle remote urls | ||
| za.store.write_fsspec(of2)# , url=url) | ||
| out = ujson.loads(of2.getvalue()) |
There was a problem hiding this comment.
This is the challenging part mentioned in #291 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to #291, that uses
tifffiledirectly instead of via kerchunk'stiff_to_zarr. However it doesn't work yet, not least becausetifffiledoesn't support zarr-python v3.docs/releases.rstapi.rst