Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove git related vars from configuration/reporting-service/variables.env.original #2291

Open
vdelendik opened this issue Jun 8, 2021 · 1 comment
Open

remove git related vars from configuration/reporting-service/variables.env.original #2291

vdelendik opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement
Milestone
2.0

Comments

@vdelendik
Copy link
Contributor

vdelendik commented Jun 8, 2021 •
edited
Loading

configuration/reporting-service/variables.env.original
it has such properties to remove when variables.env should be adjusted:
GITHUB_CLIENT_ID=
GITHUB_CLIENT_SECRET=
GITHUB_HOST=github.com

also candidate for removal:
SCM_DEFAULT_ACCOUNT_ACCESS_TOKEN=
SCM_DEFAULT_ACCOUNT_ORGANIZATION_NAME=qaprosoft
SCM_DEFAULT_ACCOUNT_REPOSITORY_NAME=carina-demo
SCM_DEFAULT_ACCOUNT_REPOSITORY_URL=https://github.com/qaprosoft/carina-demo

original ticket: zebrunner/community-edition#274
vdelendik pushed a commit that referenced this issue Oct 17, 2021
#2291: removed out-of-dated github related properties
776a457
@vdelendik vdelendik added this to the 1.26 milestone Oct 17, 2021
@vdelendik
Copy link
Contributor Author

need changes on reporting back-end side as well for github related args

@vdelendik vdelendik reopened this Oct 17, 2021
@vdelendik vdelendik modified the milestones: 1.26, 1.28 Oct 17, 2021
vdelendik pushed a commit that referenced this issue Oct 18, 2021
Revert "#2291: removed out-of-dated github related properties"
994b081 
This reverts commit 776a457.
@vdelendik vdelendik modified the milestones: 1.28, 2.0 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@vdelendik