Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase offset of style preview #20

Open
rmzelle opened this issue Apr 29, 2016 · 5 comments
Open

Increase offset of style preview #20

rmzelle opened this issue Apr 29, 2016 · 5 comments

Comments

@rmzelle
Copy link
Contributor

rmzelle commented Apr 29, 2016

The current preview overlays are positioned very close to the left, so there is only a very small mouse target for the covered styles (just two letters wide):

image

Moving the overlays a little to the right would help a lot, I think.

@rmzelle
Copy link
Contributor Author

rmzelle commented Apr 29, 2016

(it's currently difficult to switch from the "3 Biotech" preview to the "3D Printing in Medicine" preview by sliding the cursor downwards)

@rmzelle
Copy link
Contributor Author

rmzelle commented May 12, 2016

I'm also having issues in Chrome with the vertical positioning, with the top of the preview being cut off:

image

tnajdek added a commit to tnajdek/styles-repo that referenced this issue Jun 20, 2016
@dstillman
Copy link
Member

Increased offset is live

@dstillman
Copy link
Member

I can reproduce the cut-off-top issue when filtered to APA.

@dstillman
Copy link
Member

Seems like, for the cut-off issue, Drop might do the positioning incorrectly when the container/page ends? So it flips the popup up even though there's a lot more room on the page. This is more pronounced after a70db1f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants