Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong snapshots saved on Medium #438

Open
dstillman opened this issue Jul 9, 2023 · 3 comments
Open

Wrong snapshots saved on Medium #438

dstillman opened this issue Jul 9, 2023 · 3 comments
Assignees

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/106092/many-titles-have-the-wrong-snapshot

Something about client-side page loads? Not about search results, so I assume not related to eff8f30?

@adomasven
Copy link
Member

I can reproduce the Medium translator not being detected, but I get correct snapshots.

@adomasven
Copy link
Member

I've pushed 0c920b2 which is not related to this issue, but related to my findings on Medium.com. Unfortunately after it changes the URL it displays a placeholder before rendering the article, which is why the translator does not get detected. If possible, this should be addressed in the translator.

@adomasven
Copy link
Member

I did reproduce the singlefile issue once somehow, but cannot get it to occur consistently. But we were saving on the correct page, with the correct URL, in-browser, and singlefile.getPageData() was somehow saving the completely wrong document, as if it had access to the previous page's HTML, which makes no sense as it saves from the live document element. So this is likely not strictly a Zotero bug, and could even be browser-level, but unless we find a way to reliably reproduce it it's going to be hard to troubleshoot or report upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants