Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because result data is sometimes ordered differently #27

Open
zvictor opened this issue Jun 23, 2022 · 1 comment
Open

Tests fail because result data is sometimes ordered differently #27

zvictor opened this issue Jun 23, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@zvictor
Copy link
Owner

zvictor commented Jun 23, 2022

Tests can fail sometimes simply because the values coming from Fauna can be in a different order than the expected ones.

This happens mostly at:

https://github.com/zvictor/faugra/blob/a2ccb47f293af5f502a464e84423504ff3a263de/tests/specs/build-sdk.js#L193-L197

One easy way to reproduce it is by using test.only on that test. That means, replacing test(`build an sdk for the 'modularized' example, with standard cache by test.only(`build an sdk for the 'modularized' example, with standard cache.

It looks like we get one output from Fauna's expanded schema if we run our test in isolation, and a different output if we run it right after other tests.

This might be caused by how we are resetting the data in between tests.

@zvictor zvictor changed the title Tests fail because results are out of order Tests fail because result data is sometimes ordered differently Jun 23, 2022
@zvictor zvictor added the good first issue Good for newcomers label Jun 25, 2022
@zvictor
Copy link
Owner Author

zvictor commented Jul 20, 2022

98380cd has not fixed this issue. The issue number was wrong in the commit message.

@zvictor zvictor reopened this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant