Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cypress test #148

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/cypress test #148

wants to merge 5 commits into from

Conversation

sudip-md
Copy link
Contributor

@sudip-md sudip-md commented Jun 7, 2024

###Local Test Result
TestResult

Description of the Change

Added and update test cases

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 1.3.0 milestone Jun 7, 2024
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

@sudip-md thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@sudip-md sudip-md added the needs:code-review This requires code review. label Jun 7, 2024
@sudip-md sudip-md assigned jeffpaul and unassigned sudip-md Jun 7, 2024
@sudip-md sudip-md mentioned this pull request Jun 7, 2024
1 task
@jeffpaul jeffpaul linked an issue Jun 7, 2024 that may be closed by this pull request
1 task
@jeffpaul jeffpaul removed their request for review June 10, 2024 17:43
@jeffpaul jeffpaul assigned sudip-md and unassigned jeffpaul Jun 10, 2024
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for dkotter and a team September 5, 2024 20:57
@github-actions github-actions bot removed the needs:code-review This requires code review. label Sep 6, 2024
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sudip-md, Thanks for adding additional tests and raising a PR. I have updated the initialize script to fix tests failing in the GH action environment. However, I have added 2 notes on the PR. Could you please help with checking on those? Once it is resolved, we will be able to merge this.

Thank you.

it("Create Article Status", () => {
cy.visit(`wp-admin/edit-tags.php?taxonomy=pi-article-status&post_type=print-issue`);
cy.get('#tag-name').type('Active-01');
cy.get('#submit').click();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a verification step here to confirm that the article status was created successfully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdharmesh probably best if you help get things updated for this PR and merge in

cy.get('[aria-label="“Active-01” (Edit)"]').click();
cy.get('#name').clear();
cy.get('#name').type('Active-02')
cy.get('.button').click();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, Add a verification step to confirm status edited successfully. Could you please help to add verification steps for all the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires reporter feedback to better understand the request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E Tests.
3 participants