Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pre-packaged cookie dialog component #524

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Added a pre-packaged cookie acceptance dialog component, see #419.

@nicholasio We'll probably need to move this or replicate it across the other workspaces, but before I do that, wanted to see if this was what you were thinking for the pre-packaged cookie dialog.

Closes #419

How to test the Change

  1. Add the CookieDialog component on a page
  2. Visit the page and click either the accept or deny buttons
  3. Check dev tools for the cookies that have been set
  4. Reload the page to ensure the dialog doesn't reappear
  5. Delete the cookie-dialog-reviewed cookie & reload the page to confirm the dialog reappears

Changelog Entry

Added - Pre-packaged cookie dialog component

Credits

Props @bmarshall511

Checklist:

  • I agree to follow this project's [Code of Conduct]

@bmarshall511 bmarshall511 added the enhancement New feature or request label Jun 16, 2023
@bmarshall511 bmarshall511 self-assigned this Jun 16, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

⚠️ No Changeset found

Latest commit: fc7736f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview Jun 16, 2023 8:11pm

@bmarshall511 bmarshall511 changed the title Added a pre-packaged cookie dialog component, see #419 Added a pre-packaged cookie dialog component Jun 16, 2023
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio
Copy link
Member

Thanks for the PR! I'll spend some time reviewing this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider shipping a simple cookie banner notice tailored for headless sites
2 participants