Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E Tests and Upgrade Cypress to version 13 #145

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Sep 15, 2023

Description of the Change

This PR fixes the E2E failure that occurred due to Block Editor now loading in an iframe by default in WP 6.3

PR upgrades the Cypress, Cypress utils lib, and @wordpress/env. Updates needed files as part of the upgrade.

  • Bump Cypress version from 11.2.0 to 13.2.0
  • Bump @10up/cypress-wp-utils version to 0.2.0
  • Bump @wordpress/env version from 5.8.0 to 8.7.0

Also, PR upgrades minimum supported WP version from 5.7 to 5.8. (While investigating e2e failure on minimum, I found that code refactored in #56 drops supports of WP 5.7)

Closes #115
Closes #141

How to test the Change

Make sure PR PASS E2E tests check OR verify E2E tests locally.

Changelog Entry

Fixed - Ensure all E2E tests pass when running on WordPress 6.3
Changed - Bump minimum WordPress version from 5.7 to 5.8
Changed - Bump Cypress version from 11.2.0 to 13.2.0
Changed - Bump @10up/cypress-wp-utils version to 0.2.0
Changed - Bump @wordpress/env version from 5.8.0 to 8.7.0

Credits

Props @iamdharmesh @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested a review from a team as a code owner September 15, 2023 10:46
@iamdharmesh iamdharmesh requested review from dkotter and removed request for a team September 15, 2023 10:46
@github-actions github-actions bot added this to the 1.2.0 milestone Sep 15, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 15, 2023
@iamdharmesh iamdharmesh marked this pull request as draft September 15, 2023 11:09
@github-actions github-actions bot removed the needs:code-review This requires code review. label Sep 15, 2023
@iamdharmesh iamdharmesh changed the title Upgrade Cypress to version 13 Fix E2E Tests and Upgrade Cypress to version 13 Sep 15, 2023
@iamdharmesh iamdharmesh marked this pull request as ready for review September 15, 2023 11:49
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 15, 2023
@jeffpaul jeffpaul requested review from a team and removed request for jeffpaul September 15, 2023 13:34
@dkotter dkotter merged commit dd17ea2 into develop Sep 15, 2023
12 checks passed
@dkotter dkotter deleted the upkeep/141 branch September 15, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to version 13 Fix failing E2E tests
2 participants