Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 Error on PO Search Page for IPP Flow #11287

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WilliamBirdsall
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14545

🛠 Summary of changes

On the PO search page for the IPP flow, the extendSession callback was being called without a sessionURL being provided. This is due to the IPP flow being almost entirely in Ruby and not having a current session on the React side of things.

This change conditionally adds the extendSession callback only if the flow is not Opt In IPP.

📜 Testing Plan

  • Step 1: Login or create a new account via the Sinatra app and begin IPP flow
  • Step 2: Confirm that there is no 404 error in the network tab/console on the PO Search page

@WilliamBirdsall WilliamBirdsall marked this pull request as draft September 26, 2024 17:09
@WilliamBirdsall
Copy link
Contributor Author

WilliamBirdsall commented Sep 26, 2024

Notes:

  • There may be a better way to do this instead of the throwaway noop function. The DocumentCapture component already has a noop as default for onStepChange so there may be a way to use this...
  • Must ensure that extendSession still works for other flows (including hybrid). Is optedInToInPersonProofing true during hybrid? If so the conditional needs to be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant