-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14261 Add attempt count to mfa setup auth events #11293
base: main
Are you sure you want to change the base?
LG-14261 Add attempt count to mfa setup auth events #11293
Conversation
Taking a look at second_factor_attempts_count to see if that might take the place of creating a session token. |
seems to only work for OTP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work locally, but wondering if theres a way for us to push this out to a helper or concern for the verification controllers.
🎫 Ticket
Link to the relevant ticket:
LG-14261
🛠 Summary of changes
Adds a session token to track number of attempts when setting up an mfa type.
Total sum of attempts gets passed to analytics_events.
Backup codes are excluded since during setup they're added instantly.
📜 Testing Plan
Checklist of steps to confirm the changes.
properties > event_properties > mfa_attempts is registered
Attempt count will increment by failing and retrying to add mfa for example:
👀 Screenshots