Update CloudFormation template example and documentation to enable externally managed VPC and DNS #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-adampike
force-pushed
the
solutions/rond/cfn-vpc-selector
branch
3 times, most recently
from
91c83fd
to
6ca9d02
Compare
…S validation and manual CNAME validation with external DNS providers. Signed-off-by: Adam Pike <[email protected]>
…xibility in resource creation during deployment. Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
- revert object ordering to align with current template - refactor DNS name references - collpase subnet parameters to single field to simplify and allow arbitrary number - refactor Redis config into startup command parameters - remove redundant init containers from task definition - specify ARM64 platform for reduced cost Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
Signed-off-by: Adam Pike <[email protected]>
- rework to conform to other deployment examples - remove CLI instructions for brevity and clarity - include instructions for creating DNS records when necessary - include instructions for new parameters Signed-off-by: Adam Pike <[email protected]>
- introduce volume for mounting secrets - introduce sidecar (init) container with AWS CLI to mount secrets in volume - refactor secret creation to store unencoded values - moved secret read policy to task role from task execution role (task is now directly resonsible for reading secrets) - restored default service deployment configuration to allow rolling updates - removed redundant configuration entries including default values - removed redundant quotation marks
ag-adampike
force-pushed
the
solutions/rond/cfn-vpc-selector
branch
from
6ca9d02
to
818e0e3
Compare
|
Looks good so far. I have tested the first two criteria.
|
black-bryan
approved these changes
Oct 1, 2024
|
Thanks for the review, @black-bryan! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stack that is created using our current CloudFormation template example includes a VPC with public subnets and associated resources and DNS records using Route 53. This PR includes changes to enhance the template, enabling customers to:
Documentation has been updated accordingly, and includes additional changes to align with our other deployment examples.
Additional enhancements:
Testing criteria: