Add dockerfile for rolling #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
add-dockerfile
branch
from
615928d
to
79c9d73
Compare
Ryanf55
commented
Feb 3, 2024
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
wep21
reviewed
Feb 5, 2024
wep21
reviewed
Feb 5, 2024
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a dockerfile, which makes it easier to build this library. Soon, ROS 2 will start updating to run on newer versions of Ubuntu than Ubuntu 22, which makes it hard for people who choose to stay on 22.04 and
humble.Risks
This may not build all the time due to ABI breaks, and the ROS docker images for rolling are not ABI stable.
Instructions
docker build .Future improvements
Get CircleCI to build the dockerfile instead of all the crazy things it's currently doing.