fix(parsing): allow invalid decodeUriComponent parsing to occur #296

APIDevTools · Mar 6, 2024 · f9e83c0 · f9e83c0
1 parent 4c7b681
commit f9e83c0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/pointer.ts b/lib/pointer.ts
@@ -8,6 +8,14 @@ const tildes = /~/g;
 const escapedSlash = /~1/g;
 const escapedTilde = /~0/g;
 
+const safeDecodeURIComponent = (encodedURIComponent: string): string => {
+  try {
+    return decodeURIComponent(encodedURIComponent);
+  } catch {
+    return encodedURIComponent;
+  }
+};
+
 /**
  * This class represents a single JSON pointer and its resolved value.
  *
@@ -181,7 +189,7 @@ class Pointer {
 
     // Decode each part, according to RFC 6901
     for (let i = 0; i < pointer.length; i++) {
-      pointer[i] = decodeURIComponent(pointer[i].replace(escapedSlash, "/").replace(escapedTilde, "~"));
+      pointer[i] = safeDecodeURIComponent(pointer[i].replace(escapedSlash, "/").replace(escapedTilde, "~"));
     }
 
     if (pointer[0] !== "") {

diff --git a/test/specs/pointer/null.spec.ts b/test/specs/pointer/null.spec.ts
@@ -0,0 +1,8 @@
+import { describe, it } from "vitest";
+import Pointer from "../../../lib/pointer";
+
+describe("Pointers", () => {
+  it("should parse successfully", async () => {
+    Pointer.parse("#/c%d");
+  });
+});