Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where disabling automatic scroll would also disable all keyboard avoiding behavior. #416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

terribleben
Copy link

Hi there!

It looks like passing enableAutomaticScroll={false} not only disables automatic scroll, it also prevents the component from avoiding the keyboard at all. This limits the enableAutomaticScroll prop to only the actual scroll behavior.

@martsie
Copy link

martsie commented Feb 21, 2022

Having similar issues today - it looks like disabling enableAutomaticScroll disables the resizing of the scrollview, so the scrollview appears behind the keyboard on the iOS. I think using the library you'd assume setting enableAutomaticScroll to false only means that when you tap an input it won't automatically scroll and you can use utilities like scrollToFocusedInput to initiate a scroll (e.g. if you want to add some extra height for a particular input).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants