"WIP" Create auto-cpufreq-sysvinit

[AmerXz]

Run Script (Could be replaceable by auto-cpufreq-r6 runscript )

And a sysvinit daemon for auto-cpufreq generated THANKS TO :-

https://github.com/yunginnanet/sysvinit-service-generator fork of https://github.com/wyhasany/sysvinit-service-generator

It should be inside /etc/init.d/

[AmerXz]

Run script For auto-cpufreq That can make sysvinit recognise auto-cpufreq

Note You can Also use the runscript inside auto-cpufreq/scripts/auto-cpufreq-s6 By @AnasR7

[AdnanHodzic]

LGTM, but the part which I'm missing is how will the auto-cpufreq-installer detect if system user is running on is running on systemv and it's not refering to install script anywhre?

Or was there other you were envisioning of working?

[shadeyg56]

Thanks for this pr.

I do agree we should remove the auto-cpufreq-run since we already have the runfile in auto-cpufreq/scripts/auto-cpufreq-s6 to avoid redundancy and bloat

Also to repeat what Adnan suggested, the daemon installer script should be updated to include this new sysvinit service. The problem I see is what we already support openrc which uses sysvinit by default, so they both use the init process name for PID 1, so we need a way to distinguish the difference.

Something like this could work:

# snippet
elif [ "$(ps h -o comm 1)" = "init" ];then
    # Check if /etc/inittab file exists
    if [ -e "/etc/inittab" ]; then
       # sysvinit command here
    else
        # openrc stuff moved here
    fi

Additionally, the same change should be made to the daemon removal script. If that doesn't make sense, please let me know and also feel free to comment if you have any alternative ideas since I am not as familiar with openrc or sysvinit :)

[shadeyg56]

remove this file since we already have one like it

[AmerXz]

It's deleted

[AmerXz]

It's deleted

[AdnanHodzic]

It's deleted

👍, but this part is still missing:

Also to repeat what Adnan suggested, the daemon installer script should be updated to include this new sysvinit service. The problem I see is what we already support openrc which uses sysvinit by default, so they both use the init process name for PID 1, so we need a way to distinguish the difference.

Something like this could work:

# snippet
elif [ "$(ps h -o comm 1)" = "init" ];then
    # Check if /etc/inittab file exists
    if [ -e "/etc/inittab" ]; then
       # sysvinit command here
    else
        # openrc stuff moved here
    fi

Additionally, the same change should be made to the daemon removal script. If that doesn't make sense, please let me know and also feel free to comment if you have any alternative ideas since I am not as familiar with openrc or sysvinit :)

For reference see how in daemon installer script it was done for # Install script for openrc or # Install script for systemd and refer to @shadeyg56 comment above.

[AmerXz]

Sorry if I was late I want to take some time until I finish some few important things to do these days and I need to organize myself a little bit.

I will test my fork repository and will give you what happens then .

also thanks for these suggestions.

[AdnanHodzic]

No worries and take your time

[AmerXz]

# Install script for openrc / sysvinit
elif [ "$(ps h -o comm 1)" = "init" ];then
   mkdir /etc/inittab
    if [ -e "/etc/inittab" ]; then 
        echo -e "\n* Deploy auto-cpufreq sysvinit unit file"
        cp /usr/local/share/auto-cpufreq/scripts/auto-cpufreq-sysvinit /etc/init.d/auto-cpufreq
	
        echo -e "\n* "Reloading sysvinit manager configuration"
	service auto-cpufreq reload
 
        echo -e "\n* "Starting auto-cpufreq daemon (sysvinit) service"
        service auto-cpufreq start
        
        echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
	chkconfig auto-cpufreq-sysvinit on
      else
        echo -e "\n* Deploy auto-cpufreq openrc unit file"
        cp /usr/local/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq
	echo -e "\n* "Starting auto-cpufreq daemon (openrc) service"
	rc-service auto-cpufreq start

	echo -e "\n* Enabling auto-cpufreq daemon (openrc) service at boot"
	rc-update add auto-cpufreqlocal/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq

I Edited openrc script to be like that and I used this fedora resource in this link that helped me find sysvinit commands https://fedoraproject.org/wiki/SysVinit_to_Systemd_Cheatsheet

For now I didn't test the code

tell me for any suggestions if needed

I'll see you guys next time

[shadeyg56]

I will test in a VM with both init systems

[nixon87]

I am testing this right now on MX linux 23 Fluxbox 64 bit edition (non systemd) and would like to post my observations from discord (sry for the ad-hoc writing style):

Mh, it seems to work, installation went good, when i started in monitor mode it reminded me to de-install tlp, I did that restarted, now I'm running in live mode, the temperatures are the same with a different monitoring tool, unplugging the power supply gets detected, the setting to use governor is the same like in cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor from another terminal. The testing laptop is fairly old: Not setting EPP (Not supported by system) Warning: CPU turbo is not available seem plausible.

However, I get "System has not been booted with systemd as init system (PID 1 ). Can't operate. Failed to connect to bus: PC is not active .... " when starting live or monitor mode, but I ignored that for now.

I see, I have to check if I get it installed permanently.

There seems to be a problem in line 84 at the auto-cpufreq-install script:

echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
chkconfig auto-cpufreq-sysvinit on

when running

sudo auto-cpufreq -- install

• Turn off bluetooth on boot

• Deploy auto-cpufreq install script

* Deplo auto-cpufreq*remove script

There was a problem, couldn't determine GNOME Power Profiles Daemon

-----------------Running auto-cpufreq daemon install script -------------------------
/usr/local/bin/auto-cpufreq-install: line 84: syntax error near unexpected token >> ( <<
/usr/local/bin/auto-cpufreq-install: line 84: echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot" '

--------------------- auto-cpufreq daemon installed and runnin--------------------------

....
I wrote the above by hand from another pc.

Thank you for your work on non-systemd compatibility . :)

[nixon87]

Further investigating: there seems to be at least some trouble with the additional (") after "\n
from line 78 - 89

    echo -e "\n* "Reloading sysvinit manager configuration"
service auto-cpufreq reload

    echo -e "\n* "Starting auto-cpufreq daemon (sysvinit) service"
    service auto-cpufreq start

    echo -e "\n* "Enabling auto-cpufreq daemon (sysvinit) service at boot"
chkconfig auto-cpufreq-sysvinit on

and

      echo -e "\n* "Starting auto-cpufreq daemon (openrc) service"

[nixon87]

After deleting the additional " the terminal output says it doesn't know chkconfig which doesn't seem to be used by mx linux fluxbox (not installed).

[AmerXz]

I'm downloding mx linux on a vm and test the code again , I'm sorry for not giving much time to this pull request .

[AmerXz]

Ok it seems that chkconfig command is deprecated years ago and we should use insteasd sysv-rc-conf it can be found in debian repos https://packages.debian.org/bookworm/sysv-rc-conf

source https://askubuntu.com/questions/221293/why-is-chkconfig-no-longer-available-in-ubuntu/277732#277732

[nixon87]

Alrighty, there are some errors I want to post here besides chkconfig, you might have come across them in your virtual machine:

when running auto-cpufreq --install (with the changes from above)

I also get these three errors:

mkdir: cannot create folder : "/etc/inittab": file exists already

• Reloading sysvinit manager configuration
  auto-cpufreq: unrecognized service

• starting auto-cpufreq daemon (ssvinit) service
  auto-cpufreq: unrecognized service

Again, thanks for your work :)

[nixon87]

I think you need a
chmod +x /etc/init.d/auto-cpufreq
here
The copying to /etc/init.d works on my system but the script is not executable.
Maybe the same later for openrc.

[nixon87]

Just for a heads up: as written in the review the copying when running auto-cpufreq --install seems to work now. When adding chmod +x /etc/init.d/auto-cpufreq and restart the os the shell script runs as a system service at reboot. But when running auto-cpufreq --stats the daemon doesn't seem to be active. I think it's close to working but sadly I am no expert at all. I guess the sysvinit script needs some revisit and maybe the things pointed out by shadeyg56 regarding the daemon removal script. Maybe shadeyg56 can take a look at the state right now?

[AdnanHodzic]

@shadeyg56 could you please take a final look and confirm if it's all working, if it's let's merge this. Thanks!

[nixon87]

As written above I think it's not quite there yet, at least on my machine the auto-cpufreq daemon isn't active. The init system script gets started however (after the suggested changes).

[shadeyg56]

Haven't been able to test in a VM since sudo auto-cpufreq --install does not work in VMs so the OS would need to be installed natively. @AmerXz have you tested the changes?

[AmerXz]

line 92 has extra "local/share/auto-cpufreq/scripts/auto-cpufreq-openrc /etc/init.d/auto-cpufreq" added there by mistake

This is fixed in the more updated commit

[AmerXz]

I have to thank @wyhasany for making the script and @yunginnanet for his fork with the needed fixes otherwise I wouldn't be able to get auto-cpufreq-sysvinit to work

[AdnanHodzic]

I suggest you prepend "WIP" (work in progress) to title of this PR, and then please remove WIP part & announce it when it's ready for review.

Thanks!

[AmerXz]

I did some test to the code and it ran perfectly fine on mx-linux with sysvinit even after reboot , But I couldn't test it in openrc distro .

I tried to install artix with openrc but the installation was broken so I need another distro or maybe other iso version .

[rakshasha-medhi]

I did some test to the code and it ran perfectly fine on mx-linux with sysvinit even after reboot , But I couldn't test it in openrc distro .

I tried to install artix with openrc but the installation was broken so I need another distro or maybe other iso version .

Hi, I'm looking to use auto-cpufreq with MX-Linux as well but I still got the same error message in your earlier posts:
*System has not been booted with systemd as init system (PID 1). Can't operate.

how did you manage to get it work with MX-Linux and sysvinit system? would love to learn more to get this working.
or is this still undergoing tests? I notice the status is WIP.
Thanks for the great tool !

[AmerXz]

Did you clone from patch-2 branch in my fork repo ?

[AdnanHodzic]

IIRC @Angel-Karasu recently made some changes to make auto-cpufreq work with MX Linux?

Regardless, @AmerXz if this is anywhere close to merging (if it works) maybe it's good idea to start the review/merge process?

[AmerXz]

It works on mx-linux but I didn't test it on openrc distro