Unpin psutil and requests packages #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and makes total sense! Thanks |
shadeyg56
added a commit
that referenced
this pull request
Aug 5, 2024
* added the abilty to ignore certain power supplies * changed config file for ignoring power supplies * updated exapmle config file for ignoring power supplies * updated docs with ignoring power supplies * Update README.md Update image URL's * Add support for setting "Platform Profile" (#752) * Add support for setting "Platform Profile" * Add reference for Platform Profile * Fix unsafe access to PATH (#756) * Fix unsafe access to PATH * Fix leading separator if PATH is empty * Unpin psutil and requests (#759) * Remove network-online.target as a systemd-service dependency (improve boot time). Closes: #739 * minor grammer correction. * removed wonky file --------- Co-authored-by: Adnan Hodzic <[email protected]> Co-authored-by: Harsh Panchal <[email protected]> Co-authored-by: BowDown097 <[email protected]> Co-authored-by: shadeyg56 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had these packages pinned because of #654 and #707.
The psutil package had an official update so we no longer need to pull from the github repo and the requests package got updated in Nix so its now safe to unpin both of these dependencies
Also added poetry to the dev shell for Nix for convenience