-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformations between acsets involving only combinatorial data #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris-brown
changed the title
Pragmatic product of varacsets and a generalized stratification
Abstracted product of varacsets and a generalized stratification
Jun 21, 2023
kris-brown
force-pushed
the
stratification
branch
from
June 22, 2023 02:14
d3f208d
to
0c3f6c4
Compare
epatters
force-pushed
the
stratification
branch
2 times, most recently
from
July 20, 2023 16:40
8dbb553
to
4356d1d
Compare
kris-brown
changed the title
Abstracted product of varacsets and a generalized stratification
Abstracted product of varacsets
Jul 21, 2023
kris-brown
changed the title
Abstracted product of varacsets
Category of ACSets and CSetTransformations
Aug 24, 2023
kris-brown
force-pushed
the
stratification
branch
from
August 24, 2023 21:43
0008ceb
to
e76e82c
Compare
kris-brown
force-pushed
the
stratification
branch
from
September 5, 2023 18:03
4b8bf81
to
22924bb
Compare
epatters
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I just left a few small comments.
epatters
changed the title
Category of ACSets and CSetTransformations
Transformations between acsets involving only combinatorial data
Oct 2, 2023
loose kwarg for product and terminal example where distinguished object is not a leaf object SigmaMigration can return a DiagramHom with components kwarg master -> main Pragmatic -> abstract no stratify nor box product for now CSetTransformations cleanup cascade effect of fixing homsearch bug finish rebase
kris-brown
force-pushed
the
stratification
branch
from
October 3, 2023 21:23
22924bb
to
4655a45
Compare
epatters
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kris!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By considering CSetTransformations between ACSets (where naturality is not demanded on attributes) we can obtain two sorts of practical constructions:
Implementation-wise, this means we want an abstract type of
ACSetMorphism
which is implemented byACSetTransformation
andCSetTransformation
(therefore, this is changing the meaning ofCSetTransformation
, which before was anACSetTransformation
that happened to be on a schema with no attributes). There is probably a lot of functionality which is written forACSetTransformation
which would straightforwardly work forACSetMorphism
, but the minimal required functionality (e.g.dom
,compose
) for getting limits to work is all that is generalized for now.It may be the case that we want something in between, where a subset of the attributes are marked to be ignored. This would give us a kind of "LACSets" - but we would then lose the ability to do #2 above, which I see as the real value of this.
Edit: I also addressed a tiny bug in the HomSearch code where
monic
andiso
fast failure constraints were not being checked for the combinatorial Attr data.