Support for mark-as-deleted in acsets #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
changed the title
kris-brown
force-pushed
the
compat_markdeleted
branch
from
d99ec32
to
7b6138c
Compare
kris-brown
force-pushed
the
compat_markdeleted
branch
from
7b6138c
to
9ca0d62
Compare
kris-brown
force-pushed
the
compat_markdeleted
branch
from
9ca0d62
to
8a786b9
Compare
epatters
reviewed
Feb 6, 2024
added 2 commits
February 6, 2024 16:00
in_bounds, fix is_natural, homsearch generic to dense/sparse columns are used for sparse hom search as well as when initiating an ACSetTransformation with Dicts is_monic for columns sparsify, densify, trying to make columns behave like finfunctions use FinFunctions even for MarkAsDeleted tests are broken more updates hom search and acset transformations for mark as deleted rem
kris-brown
force-pushed
the
compat_markdeleted
branch
from
97b0c1e
to
7ff3971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch incorporates mark as deleted into Catlab. As was the case with VarACSets, the priority is getting support for hom search. Colimits would be the next natural thing to do. In the course of working on this, the problem of Catlab having it's own version of everything in ACSets (FinFunction machinery vs column + index machinery) was very painful.
There could be no difference in the data structure for a morphism between MaD ACSets if we just treat the data in position
iof a FinFunction (whenihas been deleted in the domain) as to-be-ignored.Constructing the ACSetTransformation data structure (e.g. as the result of a hom search) posed a challenge, as the data gets validated in many ways which do not work when parts have been deleted.
There are many challenges in making colimits work. However, since AlgebraicRewriting has support for in-place colimits (for MaD ACSets), there is no need to integrate with the normal colimit infrastructure just yet.