Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer LooseACSetTransformation when a Julia function is passed as a component #839

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Infer LooseACSetTransformation when a Julia function is passed as a component #839

merged 2 commits into from
Aug 23, 2023

Conversation

kris-brown
Copy link
Contributor

ACSetTransformation(args...) will try to deduce from the arguments whether it is a Tight or Loose transformation. It's a safe assumption that a Julia function for an attrtype means one wants a LooseACSetTransformation. This recovers pre-VarACSets behavior. Addresses #838

@neonWhiteout
Copy link
Contributor

Thank you!

@neonWhiteout neonWhiteout mentioned this pull request Aug 23, 2023
Closed
epatters
epatters reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kris!

test/categorical_algebra/CSets.jl Outdated Show resolved Hide resolved
@epatters epatters merged commit 4c71be3 into AlgebraicJulia:main Aug 23, 2023
13 checks passed
@epatters epatters mentioned this pull request Aug 23, 2023
Closed
@kris-brown kris-brown deleted the fix_loose_transformation branch August 29, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters left review comments

Assignees
No one assigned
Labels
acsets bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kris-brown @neonWhiteout @epatters