Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing compose and id methods for pointed set schemas #881

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

KevinDCarlson
Copy link
Contributor

Just needed to expand a signature for the method of id relevant to attrtypes to make sure everything in a category presented by a schema with zero maps still has an identity morphism.

@epatters epatters added the bug label Jan 11, 2024
@epatters epatters changed the title Define id for attrtypes in categories presented by a pointed set schema. Adding missing compose and id methods for pointed set schemas Jan 11, 2024
@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Jan 11, 2024
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge once the tests pass.

@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Jan 11, 2024
@epatters epatters merged commit 7facf5b into main Jan 11, 2024
12 checks passed
@epatters epatters deleted the idForPtdSetAttrtypes branch January 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants