Rename Slices to SliceCategories to avoid name conflict
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we should change the name. I would suggest renaming the module to I'm not sure why this PR deletes the modules. |
|
I think I just didn't add the renamed files on the first commit? |
epatters
changed the title
Slices to SliceCategories to avoid name conflict
|
Thanks! Can you please rebase and force-push so we get a clean commit? |
KevinDCarlson
force-pushed
the
dontExportSlices
branch
from
8a604cb
to
bd281c1
Compare
|
Yep, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia complains all the time now about Catlab and Base both exporting the word
Slices. Can we just change the name? This would be a breaking change, not sure whether there's a better approach but I think leaving it as is isn't a serious option in that the attempted export wouldn't actually work if you tried to useSlicesunqualified.