Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buildkite CI pipeline #933

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update Buildkite CI pipeline #933

wants to merge 12 commits into from

Conversation

quffaro
Copy link
Member

@quffaro quffaro commented Aug 23, 2024

Changing pipeline.yml

@epatters epatters changed the title Cm/buildkite Update Buildkite CI pipeline Aug 23, 2024
Copy link
Contributor

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

@quffaro
Copy link
Member Author

quffaro commented Oct 25, 2024

@jpfairbanks the Buildkite CI now passes here with the new dynamic pipeline and build matrix features. The former lets us make organization-wide changes to the build pipeline, while the build matrix lets us test on different combinations of environment variables, which for now is just the Julia version.

This branch allows our CI/CD to use HPC to build/test.

@jpfairbanks
Copy link
Member

Tick the task list items off that are true and LGTM

@epatters
Copy link
Member

So is the plan to make the benchmarks CI action (which is currently very slow) run in Buildkite? I don't mind merging this PR as long as the CI passes but I don't know what it's actually doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants