Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informative error for coerce_component with scalar input #936

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Informative error for coerce_component with scalar input #936

merged 1 commit into from
Sep 4, 2024

Conversation

slwu89
Copy link
Member

@slwu89 slwu89 commented Sep 4, 2024 •
edited by epatters
Loading

Closes #935

@slwu89 slwu89 requested a review from epatters September 4, 2024 16:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited by epatters
Loading

Review Checklist

Does this PR follow the development guidelines? Following is a partial checklist:

Tests

  • New features and bug fixes have unit tests
  • New modules have tests that are ultimately called by the test runner (test/runtests.jl)
  • Existing tests have not been deleted
  • Code coverage >= 90% or reduction justified in PR

Documentation

  • All exported functions, types, and constants have docstrings, written in complete sentences
  • Citations are given for any constructions, algorithms, or code drawn from external sources

Other

  • Style guidelines are followed, including indent width 2
  • Changes breaking backwards compatibility have been approved

epatters
epatters approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean! Appreciate the test.

@epatters epatters merged commit 982ea6e into AlgebraicJulia:main Sep 4, 2024
9 checks passed
@slwu89 slwu89 deleted the coerce-component-error branch September 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epatters epatters epatters approved these changes

Assignees
No one assigned
Labels
acsets code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scalars in acset transformations
2 participants
@slwu89 @epatters