Add timeout for DB access and sanitize #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rework the way of testing whether optimisation can be done using DB (previously was somewhat tailored to SQLite but of course it should work e.g. for MySQL just as well) * by default, add 100s timeout for DB access, otherwise it can happen that even for a low number of parallel jobs, the optimisation fails due to locked DB * possibility to pass kwargs in config to be used when cretaing the storage
mconcas
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework the way of testing whether optimisation can be done using DB (previously was somewhat tailored to SQLite but of course it should work e.g. for MySQL just as well)
by default, add 100s timeout for DB access, otherwise it can happen that even for a low number of parallel jobs, the optimisation fails due to locked DB
possibility to pass kwargs in config to be used when cretaing the storage