Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change python versions in tests #64

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Change python versions in tests #64

merged 3 commits into from
Oct 7, 2024

Conversation

benedikt-voelkel
Copy link
Collaborator

Remove 3.8
Keep 3.9 (used in alidist)
Add 3.12 (current version)

Remove 3.8
Keep 3.9 (used in alidist)
Add 3.12 (current version)
@benedikt-voelkel
Copy link
Collaborator Author

For some reason it seems that (at least) the max-args=10 in the .pylint file is ignored. The other possibility is that .pylint is not even read for some reason.
But right now I doubt the latter since in that case I would expect a lot more errors. I am looking into it.

Anyway, locally it works and it used to work in the CI as well.

@benedikt-voelkel
Copy link
Collaborator Author

benedikt-voelkel commented Oct 7, 2024

I see this pylint-dev/pylint#9961 and this https://bugs.launchpad.net/neutron/+bug/2083227
The latter indeed seems to be the same issue to what we see here. I will force pylint for now to be version 3.2.7

I also checked locally with various different versions to verify this problem.

@benedikt-voelkel benedikt-voelkel force-pushed the python-test branch 2 times, most recently from 03f7cb7 to 01b60cd Compare October 7, 2024 12:42
@benedikt-voelkel
Copy link
Collaborator Author

Done 🥳
It is a bit dirty but maybe that is the best we can do for now...?!

@mconcas mconcas merged commit bff3589 into master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants