Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build static site from documentation #11

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Orhideous
Copy link

It's a much more convenient and extensible way to add information about new printers and the various nuances of printing.

This PR replaces #5.

@Orhideous
Copy link
Author

Here is a preview: https://orhideous.github.io/niimprint/hardware/

If all goes well, we'll need to replace the repository URL in the mkdocs.yml

@Orhideous
Copy link
Author

@AndBondStyle Please, take a look :)

@AndBondStyle
Copy link
Owner

Taking a look... Well, I see what's cool about a separate site with docs, however with the python library of this size, is it really necessary? I think right now it's more important to just write more docs in plain markdown than migrate them to mkdocs.

With that in mind, I still appreciate the work you did. Maybe let's merge it into the "docs" branch, take some time to add more info (info about supported printers, more info about the protocol etc.), and when it'll start to look substantial, we merge it into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants