-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config files inside .GitHub folder #252
feat: config files inside .GitHub folder #252
Conversation
Signed-off-by: Luís Henrique A. Schünemann <[email protected]>
Otherwise, if it is not present or inside .github, use it as if inside .github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @LuisHenri for the PR! Just some discussion would be nice :)
Thank you! I'm all ears to discuss it. I'll take a look on your feedback when I have some time. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LuisHenri thanks a lot for the changes!
As mentioned and discussed in #249 let's prefer .github/
folder before the repo root.
Would be nice if you could do those changes 🚀
Another question. Would it be also possible for you to update docs/ARCHITECTURE.md would be nice if you find time (if not, I can also do it 👍 ). It is a small change in the mermaid diagram
…oesn't exist at all
… inside .github or root folder
Signed-off-by: Luís Henrique A. Schünemann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine. A small change in the documentation would be nice.
I've put up a pull request to add @LuisHenri! 🎉 |
@all-contributors |
I've put up a pull request to add @LuisHenri! 🎉 |
Description
Close #249
Firstly search for
.templatesyncignore
and.templateversionrc
inside .github folder. If not found, inside the root.