Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to add reviewers for pull requests #362

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

dotdc
Copy link
Contributor

@dotdc dotdc commented Jul 17, 2023

Description

Close #359

This will add the ability to add a list of additional reviewers for the generated pull requests.
Input is pr_reviewers, a comma separated list of GitHub usernames and/or teams.

Example:

- name: Template sync
  uses: AndreasAugustin/[email protected]
  with:
    github_token: ${{ secrets.CUSTOM_GITHUB_PAT }}
    source_repo_path: ${{ secrets.SOURCE_REPO_PATH }}
    pr_reviewers: firstuser,seconduser,myteam

Remark

For automation please see closing-issues-using-keywords

@dotdc
Copy link
Contributor Author

dotdc commented Jul 17, 2023

@AndreasAugustin
This is the implementation of #359.
It may require a bump to v1.1.0 as it's a new feature, do I need to change anything related to the action release?

Also used long form flags for consistency.

Let me know if there's anything to change.

@AndreasAugustin
Copy link
Owner

@AndreasAugustin This is the implementation of #359. It may require a bump to v1.1.0 as it's a new feature, do I need to change anything related to the action release?

Also used long form flags for consistency.

Let me know if there's anything to change.

@dotdc looks great!
For the new release only some documentation parts need to be updated (currently not automated yet).
Close to everywhere where v1.0.0-draft is found we need to change the version to the mentioned v1.1.0 one.

Do you want to do the search and replace? Also happy to do it (and push the tip to your PR).

Please get back to me how you would like to do it :)
After merge I will push the release button.

Thanks a lot!

@AndreasAugustin
Copy link
Owner

@all-contributors please add @dotdc for code

@allcontributors
Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @dotdc! 🎉

David Calvert and others added 2 commits July 17, 2023 22:53
@dotdc
Copy link
Contributor Author

dotdc commented Jul 17, 2023

@AndreasAugustin Updated to v1.1.0, should be good now!
The labeler CI is failing, but I don't think it's related to my change.

@AndreasAugustin
Copy link
Owner

Great! Thanks a lot!
Hmm also do not think the labeler fail is due to the changes. Need to investigate.

@AndreasAugustin AndreasAugustin merged commit 964b161 into AndreasAugustin:main Jul 17, 2023
4 of 5 checks passed
@AndreasAugustin AndreasAugustin self-assigned this Jul 17, 2023
@AndreasAugustin AndreasAugustin added the enhancement New feature or request label Jul 17, 2023
@AndreasAugustin
Copy link
Owner

@dotdc please update to v1.1.1 if you use this action.
v1.1.0 contains a bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[Feat]: additional reviewers for the generated pull requests
2 participants