Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github pat in documentation examples #423

Merged
merged 6 commits into from
Dec 30, 2023

Conversation

dotdc
Copy link
Contributor

@dotdc dotdc commented Dec 27, 2023

Description

Close #422

This will fix the GitHub PAT in the documentation examples.

Changes in the documentation:

  • Using a custom PAT everywhere, seems required, even for public repositories.
  • Using CUSTOM_GITHUB_PAT everywhere as GITHUB_* are reserved secrets names.
  • Bumped the actions versions

Remark

For automation please see closing-issues-using-keywords

Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotdc thanks a lot for the PR related to the version updates.

I don't think the former example with ${{ secrets.GITHUB_TOKEN }} is not working. Maybe I do not fully understand your issue #422

Within this repository am using those examples as actions. Please check #422 for some links to the related workflow runs.

If the former example is working, maybe we add a further example public with PAT?

README.md Outdated Show resolved Hide resolved
@AndreasAugustin
Copy link
Owner

@all-contributors please add @dotdc for maintenance

Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @dotdc! 🎉

@AndreasAugustin AndreasAugustin added bug Something isn't working documentation Improvements or additions to documentation labels Dec 30, 2023
Copy link
Contributor Author

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch includes your changes @AndreasAugustin, thanks !

@AndreasAugustin AndreasAugustin merged commit aea6128 into AndreasAugustin:main Dec 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fatal: unable to access 'https://github.com/***/': The requested URL returned error: 403
2 participants