Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SidebarBorderWidth Settings #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nicolgit
Copy link

@nicolgit nicolgit commented Jan 22, 2022

Hi guys, I have made customizable the padding size from the settings. This because I have found the default padding too wide for my preferences :-) the benefit is that you can earn valuable pixels on the screen. hope you like it.

I have updated the settings dialog

sidebar the model, and the sidebar.xaml

@ArcadeRenegade
Copy link
Owner

Hi, thanks for the PR. What is the border width though? I don't think there's a border on the sidebar. Is it the padding?

Also this updates Squirrel which may be a breaking change for the auto update.

@nicolgit
Copy link
Author

Yes correct, I mean padding 🤪

@nicolgit
Copy link
Author

I had to upgrade squirrel in order to allow to build, not sure why...

@lars18th
Copy link

Hi @nicolgit ,

This PR will provide support for negative padding?

@nicolgit
Copy link
Author

no @lars18th this sets only positive padding. Minimum value is 0

@lars18th
Copy link

no @lars18th this sets only positive padding. Minimum value is 0

And why not? Obviously, it doesn't have sense to write outside of the window space. However, if you want to reduce the border, then the padding could be negative... until the size of the real border.

Any way. When this patch will be merged?

@lars18th
Copy link

lars18th commented Nov 5, 2023

Hi @nicolgit ,

Still waiting to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants