-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Check $submenu is not NULL before adding Scan option #39424
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
cc @vykes-mac since you're most likely familiar with the changes. Let me know if you have any thoughts or feedback. |
@ecairol Thanks for the ping. Based on the described issue this guard check looks reasonable. |
@vykes-mac - Hello! We have a team51 partner who is waiting on this fix. Just so we know how to proceed with that particular site - would this patch just be added to the next release, or would it be sooner? I know it is an edge case (so not an urgent issue), but we want to know whether we should just patch it locally on this particular site until the next release. Thank you! |
I think it's okay to apply the patch on your end while waiting for the next jetpack release. |
Fixes #39423
Proposed changes:
$submenu
is empty. It is happening for sites with Jetpack CRM that have users with the role "Jetpack CRM Admin" and login using SSO.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: