-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: split component disabled prop #40210
base: trunk
Are you sure you want to change the base?
Conversation
…t, update handler's params to use prop provided prompt
… featured image modal
… general image modal
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice change!
The AiModalPromptInput has a single
disabled
prop to control both the action button and the input. When the post is empty (no title, no content), the Featured Image generator not only disables the action button, but also the prompt input. While it remains an edge case (generating a Featured Image for an empty post) there is no reason we should not allow for a user to generate a featured image on such conditions.Proposed changes:
This PR adds a secondary
actionDisabled
prop to control them separately.For this, it moves all the prompt state logic to the tip of the component tree, removing secondary (and likely contradictory) logic on the shared component AiModalPromptInput.
Other information:
Jetpack product discussion
#40198 (review)
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Generator modals (Logo AI generator, General Image AI generator, Featured Image AI generator) should remain usable, open each and confirm enabling/disabling conditions for both input and action button. Generate some image to confirm functionality with both prompt and contextual data.
Empty post (no title, no content) (worth noting, logo block and image block don't count as content):
Post with content (title and/or text blocks):